A few fixes for brakes and precoupled cargo#10
Merged
odwales20 merged 4 commits intoWallyCZ:masterfrom Apr 16, 2026
Merged
Conversation
added 3 commits
March 27, 2026 14:30
Incorrect independent brake used when cruising
When starting off or at the end of the hookup the breaks should be released.
When the train is already hooked up to the cargo the second stage pathing can be skipped.
Owner
|
Sorry, currently I have not an environment to test it. Did you tested it well? Or @odwales20 could you look at it? |
Collaborator
|
Ill have a look im currently busy in work so it will be next week |
Author
|
The braking has been tested on the DE2, DE6 and DH4. |
DM3 needed a tweak for detecting the RPM. It also now more closely follows the gear shift pattern from the wiki. It is functional but ideally we would read back the current level position so that resetting to 1,1 is not already required.
Author
|
Ive also updated the DM3 gear logic and the RPM detection code as the old one doesnt work anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mistake in the brake being used during cruise.
Added a release brake method to release the brakes at critical steps in the primary loop.
Added some logic to skip the route-to-cargo (step 2) if the cargo is already attatched.